-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4673 Improvements in user management screen #4674
Merged
Saranya-jena
merged 7 commits into
litmuschaos:master
from
JanhaviAlekar:improvements-in-user-management-screen
Jul 22, 2024
Merged
Fixes #4673 Improvements in user management screen #4674
Saranya-jena
merged 7 commits into
litmuschaos:master
from
JanhaviAlekar:improvements-in-user-management-screen
Jul 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JanhaviAlekar <[email protected]>
Signed-off-by: JanhaviAlekar <[email protected]>
Signed-off-by: JanhaviAlekar <[email protected]>
Signed-off-by: JanhaviAlekar <[email protected]>
hrishavjha
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes 🚀
amityt
approved these changes
Jun 19, 2024
amityt
approved these changes
Jul 18, 2024
Please resolve the merge conflicts @JanhaviAlekar |
andoriyaprashant
pushed a commit
to andoriyaprashant/litmus
that referenced
this pull request
Sep 7, 2024
…chaos#4674) * fix: Accept Invitation Button duplicates Signed-off-by: JanhaviAlekar <[email protected]> * fix: Delete project Invite Dialog not closing on delete invite Signed-off-by: JanhaviAlekar <[email protected]> * fix: Leave project Dialog not closing on leaving project Signed-off-by: JanhaviAlekar <[email protected]> * fix: handling create user error with toast Signed-off-by: JanhaviAlekar <[email protected]> --------- Signed-off-by: JanhaviAlekar <[email protected]> Signed-off-by: Janhavi Alekar <[email protected]> Co-authored-by: Saranya Jena <[email protected]> Signed-off-by: andoriyaprashant <[email protected]>
andoriyaprashant
pushed a commit
to andoriyaprashant/litmus
that referenced
this pull request
Sep 7, 2024
…chaos#4674) * fix: Accept Invitation Button duplicates Signed-off-by: JanhaviAlekar <[email protected]> * fix: Delete project Invite Dialog not closing on delete invite Signed-off-by: JanhaviAlekar <[email protected]> * fix: Leave project Dialog not closing on leaving project Signed-off-by: JanhaviAlekar <[email protected]> * fix: handling create user error with toast Signed-off-by: JanhaviAlekar <[email protected]> --------- Signed-off-by: JanhaviAlekar <[email protected]> Signed-off-by: Janhavi Alekar <[email protected]> Co-authored-by: Saranya Jena <[email protected]> Signed-off-by: andoriyaprashant <[email protected]>
sagnik3788
pushed a commit
to sagnik3788/litmus
that referenced
this pull request
Oct 5, 2024
…chaos#4674) * fix: Accept Invitation Button duplicates Signed-off-by: JanhaviAlekar <[email protected]> * fix: Delete project Invite Dialog not closing on delete invite Signed-off-by: JanhaviAlekar <[email protected]> * fix: Leave project Dialog not closing on leaving project Signed-off-by: JanhaviAlekar <[email protected]> * fix: handling create user error with toast Signed-off-by: JanhaviAlekar <[email protected]> --------- Signed-off-by: JanhaviAlekar <[email protected]> Signed-off-by: Janhavi Alekar <[email protected]> Co-authored-by: Saranya Jena <[email protected]> Signed-off-by: sagnik3788 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4673
Proposed changes
commit 1: Fixed duplicate "Accept Invitation" button issue
commit 2: Fixed dialog box not closing after deleting an invite
commit 3: Fixed dialog box not closing after leaving a project
commit 4: Added toast error message to indicate that the username is already taken
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.