-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] : Multiple Owner Feature architecture. #4525
[Proposal] : Multiple Owner Feature architecture. #4525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move the image to proposals/images
?
And is there any db schema changes? |
yes there's only change in the structure of owner.
|
Signed-off-by: Aryan Bhokare <[email protected]>
25e27fe
to
27dc824
Compare
Thanks, @aryan-bhokare. Is there a way to extend your proposal to allow only certain users to create projects? I am also wondering why we need to create a project on admin login? Can we make project creation an explicit action? |
Surely we will have to discuss about that. But we will be giving support for deleting the default project which is created on first login. |
|
||
### Implementation Details | ||
|
||
The proposal suggests decoupling user login and project creation. We are going to support multiple owners and add APIs `Delete Project`: to delete the projects, `Update Role`: to update role of the user in the project. We will also support multiple projects under one user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also add a couple of more sections: DB schema changes and API changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
Signed-off-by: Aryan Bhokare <[email protected]> Co-authored-by: Namkyu Park <[email protected]> Co-authored-by: Saranya Jena <[email protected]> Signed-off-by: andoriyaprashant <[email protected]>
Signed-off-by: Aryan Bhokare <[email protected]> Co-authored-by: Namkyu Park <[email protected]> Co-authored-by: Saranya Jena <[email protected]> Signed-off-by: andoriyaprashant <[email protected]>
Signed-off-by: Aryan Bhokare <[email protected]> Co-authored-by: Namkyu Park <[email protected]> Co-authored-by: Saranya Jena <[email protected]> Signed-off-by: sagnik3788 <[email protected]>
Proposed changes
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: