Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description about proxy wait #1858

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mikutas
Copy link
Contributor

@mikutas mikutas commented Oct 23, 2024

While reading https://linkerd.io/2.16/tasks/graceful-shutdown/
and https://linkerd.io/2.16/reference/proxy-configuration/ ,
I was a little confused about config.alpha.linkerd.io/proxy-wait-before-exit-seconds.

So let me suggest new description about it.

I think it's important when SIGTERM is received.

When the Linkerd proxy sidecar receives this signal, it will immediately begin a graceful shutdown where it refuses all new requests and allows existing requests to complete before shutting down.

this wait works before SIGTERM

Signed-off-by: Takumi Sue <[email protected]>
Signed-off-by: Takumi Sue <[email protected]>
@mikutas mikutas force-pushed the fix-description-proxy-wait branch from f9fe3c3 to 070c16d Compare October 23, 2024 03:02
@mikutas mikutas marked this pull request as ready for review October 23, 2024 03:11
@mikutas mikutas changed the title Fix description proxy wait Update description about proxy wait Oct 23, 2024
@wmorgan wmorgan requested review from a team and kflynn October 23, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant