Create a tool to extract a bash script from a Linera README file #3114
+127
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afck
approved these changes
Jan 11, 2025
linera-service/src/util.rs
Outdated
|
|
||
| pub fn path(&self) -> &Path { | ||
| &self.path | ||
| impl Markdown<std::io::BufReader<fs_err::File>> { |
There was a problem hiding this comment.
(Nit: I'd use std::io and remove all those std::.)
There was a problem hiding this comment.
Not sure I like use std::io so much. I added a few others instead.
linera-service/src/util.rs
Outdated
| ) -> std::io::Result<Vec<String>> { | ||
| let mut result = Vec::new(); | ||
| let mut lines = reader.lines(); | ||
| ) -> Result<(), std::io::Error> { |
There was a problem hiding this comment.
Suggested change
| ) -> Result<(), std::io::Error> { | |
| ) -> io::Result<()> { |
linera-service/src/util.rs
Outdated
| output, | ||
| "JSON_QUERY=$(jq -n --arg q \"$QUERY\" '{{\"query\": $q}}')" | ||
| )?; | ||
| writeln!(output, "QUERY_RESULT=$(curl -w '\\n' -g -X POST -H \"Content-Type: application/json\" -d \"$JSON_QUERY\" {uri} \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This was suggested by the community and team members also hacked a local solution at times.
fixes #1456
Proposal
linera extract-script-from-markdown. The command is hidden because we may arbitrarily change or remove it in the future.Test Plan
CI
Release Plan