Map view error to appropriate status; don't retry if NotFound/AlreadyExists.
#3042
+35
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deuszx
approved these changes
Dec 17, 2024
afck
added a commit
to afck/linera-protocol
that referenced
this pull request
Dec 17, 2024
afck
added a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The proxy returns a gRPC status with code
Unknownfor anyViewError, which causes the client to retry the request. For most errors, this doesn't make sense.Proposal
Map the errors to appropriate status codes. Don't retry on "not found" or "already exists" errors.
Test Plan
This brings down the 53 seconds from the scenario in #3029 to less than 9 seconds.
Release Plan
mainbranch.NodeError#3033, but that will take much longer to implement and possibly needs some discussion.Links
Blob not found on storage read#3029.