Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: adds AWS s3 mountpoints #177

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Feat: adds AWS s3 mountpoints #177

merged 6 commits into from
Dec 18, 2024

Conversation

dapineyro
Copy link
Collaborator

@dapineyro dapineyro commented Dec 18, 2024

Overview

This PR adds the new flag param --accelerate-file-staging. When used, the job submission will use "Accelerate file staging" option for quicker file staging.

Screenshot 2024-12-18 at 17 18 28

Jira

Changes

  • Adds the new --accelerate-file-staging parameter to job submission to add support for AWS S3 mountpoint for quicker file staging.
  • Updates documentation and pytest accordingly

Tests

Using docker image:

docker run --rm -it quay.io/lifebitaiorg/cloudos-cli:v2.14.0

Global variables:

MY_API_KEY="xxxxx"
CLOUDOS="https://cloudos.lifebit.ai"
WORKSPACE_ID="xxxxx"
PROJECT_NAME="API jobs"
WORKFLOW_NAME="rnatoy"
JOB_PARAMS="cloudos/examples/rnatoy.config"

Normal workflow default job run. NOT using mountpoints

cloudos job run \
    --cloudos-url $CLOUDOS \
    --apikey $MY_API_KEY \
    --workspace-id $WORKSPACE_ID \
    --project-name "$PROJECT_NAME" \
    --workflow-name $WORKFLOW_NAME \
    --job-config $JOB_PARAMS \
    --job-name cloudos_cli_default
Screenshot 2024-12-18 at 17 38 55 Screenshot 2024-12-18 at 17 40 32

Workflow job run using mountpoints

cloudos job run \
    --cloudos-url $CLOUDOS \
    --apikey $MY_API_KEY \
    --workspace-id $WORKSPACE_ID \
    --project-name "$PROJECT_NAME" \
    --workflow-name $WORKFLOW_NAME \
    --job-config $JOB_PARAMS \
    --job-name cloudos_cli_mountpoints \
    --accelerate-file-staging
Screenshot 2024-12-18 at 17 39 11 Screenshot 2024-12-18 at 17 41 01

@dapineyro dapineyro marked this pull request as draft December 18, 2024 16:41
@dapineyro dapineyro marked this pull request as ready for review December 18, 2024 16:41
@dapineyro dapineyro marked this pull request as draft December 18, 2024 16:44
@dapineyro dapineyro marked this pull request as ready for review December 18, 2024 16:44
Copy link
Contributor

@danielboloc danielboloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dapineyro dapineyro merged commit 01ba2e8 into main Dec 18, 2024
8 checks passed
@dapineyro dapineyro deleted the adds_mountpoints branch December 18, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants