Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Linux installation instructions #973

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

RogueScholar
Copy link
Contributor

The instructions for installation on Linux systems employed command syntax that is now
deprecated and often failed to provide natural contextual links to external sources of
information that cover more complex tasks in greater detail. This PR corrects those issues,
along with the following:

  • Add/update parameters to HTML iframe tag to better address
    • Safely embedding external content (allow, referrerpolicy, sandbox)
    • Web accessibility "a11y" best practices (aria-label, name, role, title)
    • Graceful handling of network constraints (loading)
    • Conversion of old HTML4 rubrics to modern CSS3 declarations (allowfullscreen -> allow="fullscreen;",
      frameborder="0" -> style="border-collapse: collapse; border-style: hidden;")
  • Convert links to Markdown "reference style" for deduplication and easier updating of targets

The instructions for installation on Linux systems
employed command syntax that is now deprecated and
often failed to provide natural contextual links
to external sources of information that covers
more complex tasks in greater detail. This commit
corrects those issues, along with the following:

- Add parameters to HTML `iframe` tag that handle
  - Safely embedding external content
    (`allow`, `referrerpolicy`, `sandbox`)
  - Web accessibility "a11y" best practices
    (`aria-label`, `name`, `role`, `title`)
  - Graceful handling of network constraints
    (`loading`)
- Convert links to Markdown "reference style" for
  deduplication and easier updating of targets

Signed-off-by: Peter J. Mello <[email protected]>
@hizzlekizzle
Copy link
Contributor

This looks great, thanks! I've been meaning to update the linux instructions for a while, but the accessibility and webdev stuff was not on my radar at all, so even better :)

@LibretroAdmin LibretroAdmin merged commit 5617359 into libretro:master Aug 19, 2024
fpscan added a commit that referenced this pull request Aug 30, 2024
Fix failure to load embedded video following #973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants