-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webrtc wasm-ext #4229
Webrtc wasm-ext #4229
Conversation
Currently stuck on |
Even though the scope is a bit bigger, I think you'll be better off binding directly to the browser APIs using I am worried that using We already have a webtransport impl that uses |
We consider |
I had a feeling you were going to say that... but you are right, it's worth the extra effort in the long run.
I did see that indeed, I'll have a look and see if I've got the bandwidth to take a crack at it. Are draft Pull Requests from a fork the preferred way to do these sorts of "build in public" work? |
💯! Much appreciated, thank you! :) The API is the same as what js-libp2p interacts with so you should also be able to get some inspiration from there! |
Opened a WIP draft PR #4248 working towards |
This PR implements `Transport` for WebRTC for browsers by using web-sys. Only the `webrtc-direct` spec is implemented. The `webrtc` spec for connecting two browsers with each other is left to a future PR. Related: libp2p/specs#475. Related #2617. Supersedes: #4229. Pull-Request: #4248. Co-authored-by: Thomas Eizinger <[email protected]>
This PR implements `Transport` for WebRTC for browsers by using web-sys. Only the `webrtc-direct` spec is implemented. The `webrtc` spec for connecting two browsers with each other is left to a future PR. Related: libp2p/specs#475. Related #2617. Supersedes: #4229. Pull-Request: #4248. Co-authored-by: Thomas Eizinger <[email protected]>
Description
Beginning of exploring an idea from @MarcoPolo about using the
wasm-ext
Transport withjs-libp2p/webrtc
imports in order to provide WebRTC through browser WebAssemblyNotes & open questions
I'm really not sure how well this will work, but worth a try to binding to the JS WebRTC browser code that is already working to the Rust library.
StreamMuxer
for theConnection
and need some insight and direction from those who know it well.Change checklist