Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing service capabilities #2911

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sfroment
Copy link

@sfroment sfroment commented Jan 9, 2025

Title

Add missing service capabilities

Description

This is used to know when a service as the pub sub capabilities

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@sfroment sfroment requested a review from a team as a code owner January 9, 2025 14:27
@achingbrain
Copy link
Member

Thanks for opening this. I hope you're not using floodsub anywhere, it's very much recommended to use gossipsub

@sfroment
Copy link
Author

sfroment commented Jan 11, 2025

@achingbrain not using just testing out some stuff with floodsub cause I was having some trouble with gossipsub. But in the end all was related to the IPColocation setting which was making the score drop after some connect/reconnect from my local to my bootstrap node.
(Also why I opened it is just cause I have some bug on the devtools extension, will try to figure them out Component pubsub did not implement the PubSub interface when using gossip sub but I believe this must be related to some lib not being on the same version as me)
BTW I asked some question on the discord on the circuit relay, I was wishing to know if this will be bad to set the maxReservation to infinity. Also the reservationClearInterval is unused currently.
Thanks for the amazing work on libp2p 🙏

EDIT: libp2p/js-libp2p-devtools#11 after digging the gossipSub impl need some update to keep being up to date with the interface
ChainSafe/js-libp2p-gossipsub#512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants