Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

Changes required(?) for importing #50

Merged
merged 3 commits into from
Oct 29, 2022
Merged

Changes required(?) for importing #50

merged 3 commits into from
Oct 29, 2022

Conversation

plauche
Copy link
Contributor

@plauche plauche commented Oct 17, 2022

No description provided.

@plauche
Copy link
Contributor Author

plauche commented Oct 17, 2022

Sorry about the whitespaces changes. I'll try to clean those up.

@achingbrain
Copy link
Member

You can also lean on aegir for this:

$ npx aegir check-project

This will bring the module in to line with the rest of the @libp2p/* projects:

  1. Make sure package.json has the correct config for the project type and is consistently formatted
  2. CI files are up to date
  3. The README is consistently formatted

The README in this module is a bit weird in that there's a Contribute block in the middle of it, just delete that and aegir will add the standard one on the end.

You can also use aegir to apply the same linting standards as every other package:

$ npx aegir lint

Though I notice this package has it's own .eslintrc so you might want to remove that as the rules clash.

Copy link
Collaborator

@ckousik ckousik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the internals like SDP to be exported? The webrtc function already exports the transport.

@ddimaria
Copy link
Collaborator

@plauche did we want this merged before the demo?

@plauche plauche force-pushed the changes-for-importing branch from 4c27d1e to 11610ac Compare October 28, 2022 20:52
@plauche plauche requested a review from ckousik October 28, 2022 20:56
@plauche
Copy link
Contributor Author

plauche commented Oct 28, 2022

@ckousik I've trimmed down the changes to the minimum required, including removing those exports which are no longer needed. However I'm not sure how to import the package without building it manually...and I don't think committing the dist/ folder is the correct way to do it. Maybe this is when we need to publish a release?

@plauche plauche force-pushed the changes-for-importing branch from 1f7ede4 to 11610ac Compare October 29, 2022 14:41
@plauche plauche merged commit ed6deda into develop Oct 29, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants