-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
Sorry about the whitespaces changes. I'll try to clean those up. |
You can also lean on $ npx aegir check-project This will bring the module in to line with the rest of the
The README in this module is a bit weird in that there's a Contribute block in the middle of it, just delete that and aegir will add the standard one on the end. You can also use aegir to apply the same linting standards as every other package: $ npx aegir lint Though I notice this package has it's own |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need the internals like SDP to be exported? The webrtc function already exports the transport.
@plauche did we want this merged before the demo? |
4c27d1e
to
11610ac
Compare
@ckousik I've trimmed down the changes to the minimum required, including removing those exports which are no longer needed. However I'm not sure how to import the package without building it manually...and I don't think committing the |
1f7ede4
to
11610ac
Compare
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.