This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
Upgradable MultiaddrConnection #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/sdp.ts
Outdated
| @@ -6,7 +6,7 @@ import { bases } from 'multiformats/basics'; | |||
|
|
|||
| const log = logger('libp2p:webrtc:sdp'); | |||
|
|
|||
| const mbdecoder = (function () { | |||
| export const mbdecoder = (function () { | |||
There was a problem hiding this comment.
Why's this exported?
| @@ -44,7 +45,7 @@ export class WebRTCStream implements Stream { | |||
| metadata: Record<string, any>; | |||
| private readonly channel: RTCDataChannel; | |||
|
|
|||
| source: Source<Uint8ArrayList> = pushable(); | |||
| _src: Source<Uint8ArrayList> = pushable(); | |||
There was a problem hiding this comment.
Do I misremember "source" being part of the interface or has the interface changed?
There was a problem hiding this comment.
No, we just use a getter/setter pattern for accessing source.
| @@ -168,6 +179,9 @@ export class WebRTCStream implements Stream { | |||
| this.readClosed = true; | |||
| this.writeClosed = true; | |||
| this.channel.close(); | |||
| if (this.closeCb) { | |||
There was a problem hiding this comment.
I had to think for a second about what cb might stand for. Perhaps the name could be more verbose.
John-LittleBearLabs
approved these changes
Sep 28, 2022
src/options.ts
Outdated
| @@ -6,5 +6,4 @@ export interface WebRTCListenerOptions extends CreateListenerOptions { | |||
| // channelOptions?: WebRTCReceiverInit | |||
| } | |||
|
|
|||
| export interface WebRTCDialOptions extends DialOptions { | |||
| } | |||
| export interface WebRTCDialOptions extends DialOptions {} | |||
There was a problem hiding this comment.
Shouldn't there be something here specifying your upgrader as the default one?
19 tasks
4 tasks
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the new Upgrader interface to use in-built encryption and multiplexing of a WebRTC connection.