Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

Add CI templates #22

Merged
merged 9 commits into from
Sep 13, 2022
Merged

Add CI templates #22

merged 9 commits into from
Sep 13, 2022

Conversation

ddimaria
Copy link
Collaborator

@ddimaria ddimaria commented Aug 31, 2022

Note: CI linting is failing (over 900 issues). We will submit a lint-fix PR once all code is in develop.

  • Add the CI workflow templates from other libp2p projects
  • Add linting scripts to package.json
  • Document in README

refs: libp2p/specs#412

@ddimaria ddimaria self-assigned this Aug 31, 2022
@ddimaria ddimaria marked this pull request as ready for review September 6, 2022 17:07
.github/workflows/js-test-and-release.yml Outdated Show resolved Hide resolved
.github/workflows/js-test-and-release.yml Outdated Show resolved Hide resolved
@ddimaria ddimaria requested a review from ckousik September 12, 2022 20:42
Copy link
Contributor

@John-LittleBearLabs John-LittleBearLabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good luck with the merge conflicts.

"dist/src",
"!dist/test",
"!**/*.tsbuildinfo"
],
"scripts": {
"build": "aegir build",
"test": "aegir test --target browser",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your CI scripts expect a bunch of specific test:X scripts, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't take credit for these, they are lifted from other transport repos. There was a distinct pattern across them all.

@ddimaria ddimaria merged commit 94d4701 into develop Sep 13, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants