This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
Transport implements initializable #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,6 +45,7 @@ export class WebRTCTransport implements Transport { | |||
| } | |||
|
|
|||
| async _connect(ma: Multiaddr, options: WebRTCDialOptions) { | |||
| let registrar = (await this.components.promise).getRegistrar(); | |||
There was a problem hiding this comment.
What is registrar used for?
|
I suppose we can. But since the prologue support has landed in the upstream js-libp2p-noise, perhaps we could merge that other PR into develop? The only question is the correct reference in package.json for the new new noise (I don't believe there's a release yet, so we might need to do the git thing). |
17 tasks
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@John-LittleBearLabs Could we merge this into your existing PR? I can then work on connection using your branch. It allows access to the registrar and metrics components.