swarm: skip dialing WebTransport addresses when we have QUIC addresses #1756
Conversation
There was a problem hiding this comment.
Do I understand correctly that this would drop all webtransport addresses in case there is a single quic address?
In case a node advertises the following two address, the local node should still dial both, right?
"/ip4/1.2.3.4/udp/443/quic
"/ip4/5.6.7.8/udp/443/quic/webtransport
In other words, only if the addresses are equal on everything before quic, only then should the QUIC address replace the webtransport address.
Does that make sense?
Yes, that would be better, but also more code. Not sure if it's worth the complexity. |
|
Actually, this probably won't be too hard. I'll update the PR. |
| if isQUIC(addr) { | ||
| hasQuic = true | ||
| } | ||
| if isWebTransport(addr) { | ||
| hasWebTransport = true | ||
| } |
There was a problem hiding this comment.
| if isQUIC(addr) { | |
| hasQuic = true | |
| } | |
| if isWebTransport(addr) { | |
| hasWebTransport = true | |
| } | |
| hasQuic = isQuic(addr) | |
| hasWebTransport = isWebTransport(addr) |
There was a problem hiding this comment.
Oh wait, this is not correct. The ifs are in a loop. Will revert.
marten-seemann
force-pushed
the
dont-dial-webtransport-when-have-quic
branch
from
cdd27b7 to
ebd6827
Compare
|
Merging this simple version now. We can still have better logic later (or implement the proper Happy Eyeballs fix later). |
Question: Should we have something similar for WebSocket and TCP?