Add Resolver interface to transport #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
force-pushed
the
marco/1597/resolve-in-transports
branch
from
966805b to
5bce716
Compare
MarcoPolo
force-pushed
the
marco/1597/resolve-in-transports
branch
from
54e85e1 to
2dc2ace
Compare
p2p/transport/websocket/websocket.go
Outdated
| fallthrough | ||
| case ma.P_DNS6: | ||
| fallthrough | ||
| case ma.P_DNSADDR: |
There was a problem hiding this comment.
This is equivalent to:
case ma.P_DNS, ma.P_DNS4, ma.P_DNS6, ma.P_DNSADDR:Right?
There was a problem hiding this comment.
Maybe easier: maddr.ValueForProtocol
There was a problem hiding this comment.
That would be multiple loops to get the value, right?
Have you considered requiring the repo by its commit hash? That would allow you to run CI (and would have caught at least one of the issues here, the copying of the mutex). |
Co-authored-by: Marten Seemann <[email protected]>
Yep! |
MarcoPolo
commented
Sep 9, 2022
marten-seemann
approved these changes
Sep 13, 2022
This was referenced Sep 19, 2022
Closed
lidel
added a commit
to libp2p/go-libp2p-relay-daemon
that referenced
this pull request
Oct 5, 2022
includes libp2p/go-libp2p#1719 which fixes secure websockets (wss) by having the websocket transport resolve a multiaddr with a dns hostname and /wss into a multiaddr that explictly defines the sni component. e.g. converts /dns4/example.com/tcp/1234/wss into /dns4/example.com/tcp/1234/tls/sni/example.com/ws
lidel
added a commit
to libp2p/go-libp2p-relay-daemon
that referenced
this pull request
Oct 5, 2022
includes libp2p/go-libp2p#1719 which fixes secure websockets (wss) by having the websocket transport resolve a multiaddr with a dns hostname and /wss into a multiaddr that explictly defines the sni component. e.g. converts /dns4/example.com/tcp/1234/wss into /dns4/example.com/tcp/1234/tls/sni/example.com/ws
lidel
added a commit
to libp2p/go-libp2p-relay-daemon
that referenced
this pull request
Oct 5, 2022
includes libp2p/go-libp2p#1719 which fixes secure websockets (wss) by having the websocket transport resolve a multiaddr with a dns hostname and /wss into a multiaddr that explictly defines the sni component. e.g. converts /dns4/example.com/tcp/1234/wss into /dns4/example.com/tcp/1234/tls/sni/example.com/ws
lidel
added a commit
to libp2p/go-libp2p-relay-daemon
that referenced
this pull request
Oct 5, 2022
includes libp2p/go-libp2p#1719 which fixes secure websockets (wss) by having the websocket transport resolve a multiaddr with a dns hostname and /wss into a multiaddr that explictly defines the sni component. e.g. converts /dns4/example.com/tcp/1234/wss into /dns4/example.com/tcp/1234/tls/sni/example.com/ws
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1597
This adds a new Resolver interface that can be optionally implemented by transports. This lets a transport resolve a single multiaddr into many multiaddrs, while still letting the swarm handle concurrency in the actual dialing step.
This PR also fixes secure websockets (wss) by having the websocket transport resolve a multiaddr with a dns hostname and
/wssinto a multiaddr that explictly defines thesnicomponent. e.g. converts/dns4/example.com/tcp/1234/wssinto/dns4/example.com/tcp/1234/tls/sni/example.com/ws. This is useful so that when the swarm resolves the dns4 address the websocket transport still has access to the hostname so that it can properly set the SNI. e.g. the swarm converts/dns4/example.com/tcp/1234/tls/sni/example.com/wsinto/ip4/1.2.3.4/tcp/1234/tls/sni/example.com/ws, and the websockets transport still knows what the SNI should be when it's asked to dial.Tests will fail until multiformats/go-multiaddr#182 is merged and released.