This repository has been archived by the owner on May 26, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes libp2p/go-libp2p#1428
Hey, I just started to add the
DisableReuseport
options. It seems to be working as expected with some cellular operators that couldn't maintain the connection (I tried with this script https://github.com/gfanton/libp2p-reuseport-test)Just some few things:
conn_tests
with a simple table test case to test everything conn related with the reuseport_on/offnet.ListenUDP
instead ofnet.DialUDP
for the Dial method to work, otherwise the call to theWriteTo
method fails.Also there are two tests that currently fail with the reuseport disabled:
TestHolePunching
TestStatelessReset
Do these tests make sense when used with resuseport disabled?