fix: load plugin/ in autocmds before 'loadplugins'

[lewis6991]

No description provided.

[zeertzjq]

This change breaks plugins that are configured via global variables. Now pckr.nvim must be loaded after the global variables are set.

[lewis6991]

Sorry I don't understand. I load pckr before plugin/ is loaded. The variable is just used to signal when plugin/* is sourced during initialisation instead of using VimEnter which happens later.

[zeertzjq]

Sorry, it seems that the breakage I observed came from something else.

[lewis6991]

Ok. Do you have any more details?

[zeertzjq]

Hmm, it seems that the behavior of pckr.nvim hasn't changed, but I somehow just noticed that pckr.nvim loads plugin/ from the packages immediately after require('pckr').add().

[lewis6991]

Only if run pckr after initialisation, otherwise when else would you load plugin/? I've tried to make sure to follow the semantics of :packadd as close as possible.

[zeertzjq]

Hmm, it seems to do that in init.lua as well. With the following init.lua:

local function bootstrap_pckr()
  local pckr_path = vim.fn.stdpath("data") .. "/pckr/pckr.nvim"

  if not (vim.uv or vim.loop).fs_stat(pckr_path) then
    vim.fn.system({
      'git',
      'clone',
      "--filter=blob:none",
      'https://github.com/lewis6991/pckr.nvim',
      pckr_path
    })
  end

  vim.opt.rtp:prepend(pckr_path)
end

bootstrap_pckr()

print(vim.g.undotree_DiffCommand)
require('pckr').add{
  { 'mbbill/undotree', start = true },
}
print(vim.g.undotree_DiffCommand)

It prints:

nil
diff

which means calling require('pckr').add() loads the plugin/ directories.

[lewis6991]

Looks like a bug with start = true.

[lewis6991]

This behaviour is caused by do_loadplugins() in pckr/loader.lua. You can disable this by setting _native_loadplugins = true.

I implemented a custom loadplugins behaviour because the built-in implementation was slow. However I think I might have resolved this in neovim/neovim#24191

Need to re-assess if it is still necessary. #49