Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing methods to set metadata in primitives #1053

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open

Add missing methods to set metadata in primitives #1053

wants to merge 5 commits into from

Conversation

juangm
Copy link
Collaborator

@juangm juangm commented Jan 7, 2025

No description provided.

@juangm juangm requested a review from cesarenaldi January 7, 2025 20:33
@juangm juangm self-assigned this Jan 7, 2025
@height Height
Copy link

height bot commented Jan 7, 2025

This pull request has been linked to 1 task:

  • T-23479 JS: action add setFeedMetadata, setNamespaceMetadata, setGroupMetadata, setGraphMetadata (unlink task)

💡Tip: Add "Close T-23479" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8d193f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
lens-sdk-example-web-wagmi ⬜️ Ignored (Inspect) Jan 10, 2025 1:48pm

cesarenaldi
cesarenaldi reviewed Jan 9, 2025
View reviewed changes
packages/client/src/actions/feed.ts Outdated
* });
* ```
*
* @param client - The session client logged as a builder.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @param client - The session client logged as a builder.
* @param client - The session client logged in as a builder.

cesarenaldi
cesarenaldi reviewed Jan 10, 2025
View reviewed changes
packages/client/src/actions/graph.ts Outdated
* ```ts
* const result = await setGraphMetadata(sessionClient, {
* graph: evmAddress('0xe2f2a5C287993345a840db3B0845fbc70f5935a5'),
* metadataUri: 'https://example.com/feed-metadata.json',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uri

cesarenaldi
cesarenaldi reviewed Jan 10, 2025
View reviewed changes
packages/client/src/actions/feed.ts Outdated
* ```ts
* const result = await setFeedMetadata(sessionClient, {
* feed: evmAddress('0xe2f2a5C287993345a840db3B0845fbc70f5935a5'),
* metadataUri: 'https://example.com/feed-metadata.json',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uri

cesarenaldi
cesarenaldi reviewed Jan 10, 2025
View reviewed changes
packages/client/src/actions/group.ts Outdated
* ```ts
* const result = await setGroupMetadata(sessionClient, {
* group: evmAddress('0xe2f2a5C287993345a840db3B0845fbc70f5935a5'),
* metadataUri: 'https://example.com/feed-metadata.json',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uri

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with lens:// ...example

cesarenaldi
cesarenaldi reviewed Jan 10, 2025
View reviewed changes
packages/client/src/actions/namespace.ts Outdated
* ```ts
* const result = await setNamespaceMetadata(sessionClient, {
* namespace: evmAddress('0xe2f2a5C287993345a840db3B0845fbc70f5935a5'),
* metadataUri: 'https://example.com/feed-metadata.json',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

cesarenaldi
cesarenaldi reviewed Jan 10, 2025
View reviewed changes
packages/client/src/actions/username.ts Outdated
Comment on lines 119 to 121
* filter: {
* owner: evmAddress('0xe2f2a5C287993345a840db3B0845fbc70f5935a5'),
* },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* filter: {
* owner: evmAddress('0xe2f2a5C287993345a840db3B0845fbc70f5935a5'),
* },
* filter: {
* owner: evmAddress('0xe2f2a5C287993345a840db3B0845fbc70f5935a5'),
* },

cesarenaldi
cesarenaldi reviewed Jan 10, 2025
View reviewed changes
packages/graphql/src/enums.ts
/**
* Enum for AppUsersOrderBy.
*/
export enum AppUsersOrderBy {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please hook this into the scalar config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesarenaldi cesarenaldi cesarenaldi left review comments

Assignees

@juangm juangm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juangm @cesarenaldi