fix(transformer): strip typeof import statements using regexp

leegeunhyeok · Sep 14, 2024 · 52f7c80 · 52f7c80 · github-actions · Sep 14, 2024
1 parent 443e727
commit 52f7c80
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/packages/transformer/lib/pipelines/builder.ts b/packages/transformer/lib/pipelines/builder.ts
@@ -10,7 +10,7 @@ import type {
 import { babelPresets } from '../transformer';
 import type { TransformPipeline } from './pipeline';
 
-const FLOW_SYMBOL = ['@flow', '@noflow'] as const;
+const FLOW_SYMBOL = ['@flow', '@noflow', 'import typeof'] as const;
 
 export abstract class TransformPipelineBuilder<
   Step extends TransformStep<unknown>,

diff --git a/packages/transformer/lib/transformer/sucrase/sucrase.ts b/packages/transformer/lib/transformer/sucrase/sucrase.ts
@@ -2,12 +2,11 @@ import { transform, type Transform } from 'sucrase';
 import type { SyncTransformer } from '../../types';
 
 const TRANSFORM_FOR_STRIP_FLOW: Transform[] = ['flow', 'jsx'];
+const typeofImportRegExp =
+  /import\s+typeof\s+[^;]+\s+from\s+['"][^'"]+['"];\s*/g;
 
 const stripFlowTypeofImportStatements = (code: string): string => {
-  return code
-    .split('\n')
-    .filter((line) => !line.startsWith('import typeof '))
-    .join('\n');
+  return code.replace(typeofImportRegExp, '');
 };
 
 export const stripFlowWithSucrase: SyncTransformer<void> = (code, context) => {
St.^❔	Category	Percentage	Covered / Total
🔴	Statements	16.12%	328/2035
🔴	Branches	16.24%	82/505
🔴	Functions	10.8%	65/602
🔴	Lines	15.41%	298/1934