Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Abort Controller Polyfill #201

Merged
merged 4 commits into from
Dec 14, 2022

Conversation

TaylorBeeston
Copy link
Collaborator

@TaylorBeeston TaylorBeeston commented Dec 14, 2022

Closes #122

Overview

🎟 Relevant Jira Issues

📚 What is the context and goal of this PR?

In contexts where modules must be fully specified, our abort-controller polyfill can error out due to an unmaintained package.

🥴 TL; RL:

Skips using the polyfill logic of the unmaintained package and instead does the polyfill manually!

💡 Feature Breakdown (screenshots & videos encouraged!)

🛠 Important tradeoffs made:

🔍 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (refactor, documentation update, etc)

💳 Does This Create Any New Technical Debt? ( If yes, please describe and add JIRA TODOs )

  • No
  • Yes

Testing

🔬 How Can Someone QA This?

Import this branch into a new CRA5 app and make sure you don't run into any abort-controller issues

📱 🖥 Which devices would you like help testing on?

🧪 Code Coverage

Documentation

📜 Gitbook

📊 Storybook

✅ PR Checklist

  • Related to a Jira issue (create one if not)
  • My code follows style guidelines (eslint / prettier)
  • I have manually tested common end-2-end cases
  • I have reviewed my code
  • I have commented my code, particularly where ambiguous
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to gitbook documentation

🚀 Ready to squash-and-merge?:

  • Code is backwards compatible
  • There is not a "Do Not Merge" label on this PR
  • I have thoughtfully considered the security implications of this change.
  • This change does not expose new public facing endpoints that do not have authentication

@changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2022

🦋 Changeset detected

Latest commit: 2090b9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@learncard/core Patch
@learncard/chapi-example Patch
@learncard/snap-chapi-example Patch
@learncard/snap-example-dapp Patch
@learncard/create-http-bridge Patch
@learncard/cli Patch
@learncard/react Patch
learn-card-discord-bot Patch
@learncard/meta-mask-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for learncarddocs canceled.

Name Link
🔨 Latest commit 2090b9f
🔍 Latest deploy log https://app.netlify.com/sites/learncarddocs/deploys/639a4f07149f7d0008071402

@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for learn-card-chapi-example canceled.

Name Link
🔨 Latest commit 2090b9f
🔍 Latest deploy log https://app.netlify.com/sites/learn-card-chapi-example/deploys/639a4f074985c70008565dc2

Copy link
Collaborator

@smurflo2 smurflo2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@TaylorBeeston TaylorBeeston merged commit d6ebc5b into main Dec 14, 2022
@TaylorBeeston TaylorBeeston deleted the manual-abort-controller-polyfill branch December 14, 2022 22:38
@github-actions github-actions bot mentioned this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

abort-controller dependency problem
2 participants