forked from juanfont/headscale
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Headscale: Added an option to set an Access-Control-Allow-Origin resp… #1
Open
Jisse-Meruma
wants to merge
8
commits into
updated
Choose a base branch
from
enable-cors-with-config
base: updated
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jisse-Meruma
commented
Dec 12, 2024
- [ x ] read the CONTRIBUTING guidelines
- raised a GitHub issue or discussed it on the projects chat beforehand
- added unit tests
- added integration tests
- [ x ] updated documentation if needed
- updated CHANGELOG.md
* consolidate scheduled tasks into one goroutine Signed-off-by: Kristoffer Dalby <[email protected]> * rename Tailcfg dns struct Signed-off-by: Kristoffer Dalby <[email protected]> * add dns.extra_records_path option Signed-off-by: Kristoffer Dalby <[email protected]> * prettier lint Signed-off-by: Kristoffer Dalby <[email protected]> * go-fmt Signed-off-by: Kristoffer Dalby <[email protected]> --------- Signed-off-by: Kristoffer Dalby <[email protected]>
yuri91
requested changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
squash the commits together. other than that it looks clean to me.
Make the PR to upstream first thing on Monday (so you don't get potentially pinged on the weekend).
Jisse-Meruma
force-pushed
the
enable-cors-with-config
branch
from
December 13, 2024 14:22
2c2085a
to
39bd024
Compare
Jisse-Meruma
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Dec 13, 2024
Fixes juanfont#2259 Signed-off-by: Kristoffer Dalby <[email protected]>
Fixes juanfont#2291 Signed-off-by: Kristoffer Dalby <[email protected]>
yuri91
approved these changes
Dec 16, 2024
Jumpcloud send invalid json, so we need to handle it. Fixes juanfont#2293 Signed-off-by: Kristoffer Dalby <[email protected]>
* Fix excess error message during writes Fixes juanfont#2290 Signed-off-by: Kristoffer Dalby <[email protected]> * retry filewatcher on removed files This should handled if files are deleted and added again, and for rename scenarios. Fixes juanfont#2289 Signed-off-by: Kristoffer Dalby <[email protected]> * test more write and remove in filewatcher Signed-off-by: Kristoffer Dalby <[email protected]> --------- Signed-off-by: Kristoffer Dalby <[email protected]>
Jisse-Meruma
force-pushed
the
enable-cors-with-config
branch
2 times, most recently
from
December 18, 2024 15:47
0c8b45b
to
4183039
Compare
…onse header to enable Cross-Origin Resource Sharing (CORS)
Jisse-Meruma
force-pushed
the
enable-cors-with-config
branch
from
December 18, 2024 16:27
e07c42b
to
dfad6a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.