Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headscale: Added an option to set an Access-Control-Allow-Origin resp… #1

Open
wants to merge 8 commits into
base: updated
Choose a base branch
from

Conversation

Jisse-Meruma
Copy link

  • [ x ] read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • [ x ] updated documentation if needed
  • updated CHANGELOG.md

@Jisse-Meruma Jisse-Meruma requested a review from yuri91 December 12, 2024 15:50
* consolidate scheduled tasks into one goroutine

Signed-off-by: Kristoffer Dalby <[email protected]>

* rename Tailcfg dns struct

Signed-off-by: Kristoffer Dalby <[email protected]>

* add dns.extra_records_path option

Signed-off-by: Kristoffer Dalby <[email protected]>

* prettier lint

Signed-off-by: Kristoffer Dalby <[email protected]>

* go-fmt

Signed-off-by: Kristoffer Dalby <[email protected]>

---------

Signed-off-by: Kristoffer Dalby <[email protected]>
Copy link
Member

@yuri91 yuri91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squash the commits together. other than that it looks clean to me.
Make the PR to upstream first thing on Monday (so you don't get potentially pinged on the weekend).

@Jisse-Meruma Jisse-Meruma force-pushed the enable-cors-with-config branch from 2c2085a to 39bd024 Compare December 13, 2024 14:22
@Jisse-Meruma Jisse-Meruma added bug Something isn't working and removed bug Something isn't working labels Dec 13, 2024
@Jisse-Meruma Jisse-Meruma requested a review from yuri91 December 16, 2024 09:24
Jumpcloud send invalid json, so we need to handle it.

Fixes juanfont#2293

Signed-off-by: Kristoffer Dalby <[email protected]>
* Fix excess error message during writes

Fixes juanfont#2290

Signed-off-by: Kristoffer Dalby <[email protected]>

* retry filewatcher on removed files

This should handled if files are deleted and added again, and for rename
scenarios.

Fixes juanfont#2289

Signed-off-by: Kristoffer Dalby <[email protected]>

* test more write and remove in filewatcher

Signed-off-by: Kristoffer Dalby <[email protected]>

---------

Signed-off-by: Kristoffer Dalby <[email protected]>
@Jisse-Meruma Jisse-Meruma force-pushed the enable-cors-with-config branch 2 times, most recently from 0c8b45b to 4183039 Compare December 18, 2024 15:47
…onse header to enable Cross-Origin Resource Sharing (CORS)
@Jisse-Meruma Jisse-Meruma force-pushed the enable-cors-with-config branch from e07c42b to dfad6a1 Compare December 18, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants