Mobile: Fixes #8707: Fix not all dropdown items focusable with VoiceOver #8714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ItemList.jsonly rendered items that were currently visible and thus VoiceOver was, if no items were partially outside of the ScrollView's viewport, unable to scroll the viewport and load more items. This pull request updatesDropdown.tsxto use React Native's built-inFlatListinstead of the customItemList.js.Like
ItemList,FlatListshould only render items in/around the ScrollView's viewport.This is a version of #8708 with fewer changes to
Dropdown.tsx.Resolves #8707.
Notes
ItemList.jsis unused and has thus been deleted.