Desktop: Fixes #11597: OneNote Importer should only use text on fallback title #11598
+179
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11597
Summary
OneNote has a similar behaviour to Joplin where when a note doesn't have a title it uses the first paragraph as the fallback title. Differently from Joplin, this doesn't seems to alter the original note, happening only in the user interface, since the title property is empty in these cases.
The logic already implemented gets the first Section outline (equivalent to the first paragraph) and uses it as the title, the missing logic here was to remove the hyperlink part of it when it exists so the title doesn't get too long causing.
Note
This change only modifies the content of the title, it shouldn't affect the content shown in the body
Testing
I added a test notebook with three types of notes without title:
onenote:
protocol