Fix parsing multidimensional array from multipart #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During parsing a multipart array there is a check if the current segment is empty to set a value. Basically, adding a new element to an array.
It works perfectly fine for simple arrays like:
But sometimes the array key is also specified, fx:
Or something more complicated as Laravel Nova does:
In that case the check:
Will fail as
empty
considers the first array key ('0') as trueThus each time a new array element created instead of adding to the existing one, which causes some unexpected result
Report to that issue in the Nova issues repository: laravel/nova-issues#6229