Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rerank model type for LocalAI provider #3952

Merged
merged 6 commits into from
May 11, 2024
Merged

Add rerank model type for LocalAI provider #3952

merged 6 commits into from
May 11, 2024

Conversation

thiner
Copy link
Contributor

@thiner thiner commented Apr 28, 2024 •
edited
Loading

Description

This PR extends API support for LocalAI backend. Below API will be added:

  • rerank

This PR fixes #3524

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

First draft version, haven't gotten resources to test it.

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

takatost
takatost requested changes Apr 29, 2024
View reviewed changes
web/yarn.lock Outdated Show resolved Hide resolved
thiner
thiner commented May 8, 2024
View reviewed changes
Copy link
Contributor Author

@thiner thiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

web/yarn.lock Outdated Show resolved Hide resolved
@thiner thiner marked this pull request as ready for review May 10, 2024 02:06
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. ⚙️ feat:model-runtime labels May 10, 2024
takatost
takatost approved these changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 11, 2024
@takatost takatost merged commit a588df4 into langgenius:main May 11, 2024
7 checks passed
zxhlyh pushed a commit that referenced this pull request May 13, 2024
@thiner @zxhlyh
Add rerank model type for LocalAI provider (#3952)
149ee41
@takatost takatost mentioned this pull request May 13, 2024
Merged
dengpeng pushed a commit to dengpeng/dify that referenced this pull request Jun 16, 2024
@thiner @dengpeng
Add rerank model type for LocalAI provider (langgenius#3952)
9f44db1
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
@thiner
Add rerank model type for LocalAI provider (langgenius#3952)
ba8b50c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takatost takatost takatost approved these changes

Assignees
No one assigned
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend API support for LocalAI
2 participants
@thiner @takatost