Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced schema fixes #34

Merged
merged 7 commits into from
Jan 10, 2025

Conversation

alexthomas93
Copy link
Collaborator

@alexthomas93 alexthomas93 commented Jan 9, 2025

Description

This PR fixes a few issues with the enhanced schema function of the Neo4jGraph class:

  • Updates the schema_counts query to use the apoc.meta.graph procedure rather than the apoc.meta.graphSample procedure, which isn't as accurate.
  • Removes the previously added default setting suppressing all warnings from the Neo4j driver.
  • Adds session_params parameter to the query method of Neo4jGraph allowing for the passing of session specific parameters to the Neo4j driver.
  • Updates the Neo4jGraph.query call used to get the enhanced schema so that specific warnings raised by this call are suppressed.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Project configuration change

Complexity

Medium

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual tests

Checklist

  • Unit tests updated
  • Integration tests updated
  • CHANGELOG.md updated

@alexthomas93
Copy link
Collaborator Author

@CodiumAI-Agent /update_changelog

@CodiumAI-Agent
Copy link

Changelog updates: 🔄

2025-01-09

Fixed

  • Resolved issues with enhanced schema handling and database connection configurations.
  • Improved error handling for Neo4j driver initialization and query execution.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

@alexthomas93 alexthomas93 merged commit 06db048 into langchain-ai:main Jan 10, 2025
8 checks passed
@alexthomas93 alexthomas93 deleted the fix/enhanced-schema branch January 10, 2025 13:02
@CodiumAI-Agent
Copy link

Changelog updates: 🔄

2025-01-10

Changed

  • Updated Neo4jGraph.query to support session-specific parameters and improved schema query accuracy by using apoc.meta.graph.

Fixed

  • Removed default suppression of all warnings from the Neo4j driver in Neo4jGraph.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants