Provide optional parameter for embedding dimension in Neo4jVector #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CodiumAI-Agent /update_changelog |
|
Changelog updates: 🔄 2025-01-08Added
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From this issue.
When loading an existing index via Neo4jVector.from_existing_index(), a singleton of Neo4jVector is created, which in init calls the embedding model to find the number of embedding dimensions..
This call to the embedding model is a headache in CICD, where you do not want to and can not call third-party embedding services during integration tests.
Type of Change
Complexity
Low
How Has This Been Tested?
Checklist