-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Makefile #302
Update Makefile #302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guilt
Thanks for submitting this update, the help improvements look good. Some minor comments to make help messages consistent, looks good otherwise.
libs/aws/Makefile
Outdated
tests: ## Run all Tests | ||
poetry run pytest $(TEST_FILE) | ||
|
||
test: ## Run Individual Test: make test TEST_FILE=test.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Like the sample commands.
f0bd840
to
7eef101
Compare
Co-authored-by: Piyush Jain <[email protected]>
7eef101
to
41c214f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Issue or Problem Addressed
For a new Developer who is starting with the development, list of commands to learn in
make
can be exhausting.Description
Makefile
.help
section of Makefile.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This as tested on my Laptop.
List of Tests Added
N/A
Test Procedure
make
now lists all help targetsTest Configuration
3.12.4
Darwin 23.6.0 Darwin Kernel Version 23.6.0
Review Checklist: