Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Build Compass components with Go 1.14 #1270

Merged

Conversation

NickyMateev
Copy link
Member

@NickyMateev NickyMateev commented May 4, 2020

Description

Some unit tests make error assertions which are breaking on Go 1.14.X due to missing quotation signs.

Changes proposed in this pull request:

  • Adapt unit tests with missing quotes in certain error test expectations

Reference breaking change in Go: golang/go#37630

@kyma-bot
Copy link

kyma-bot commented May 4, 2020

Hi @NickyMateev. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CLAassistant
Copy link

CLAassistant commented May 4, 2020

CLA assistant check
All committers have signed the CLA.

@pkosiec
Copy link
Contributor

pkosiec commented May 4, 2020

/ok-to-test

@pkosiec
Copy link
Contributor

pkosiec commented May 4, 2020

/test all

@pkosiec
Copy link
Contributor

pkosiec commented May 4, 2020

@NickyMateev Hmm, the tests won't pass as still on Prow we use older Go while running tests:
https://github.com/kyma-project/test-infra/blob/master/templates/config.yaml#L129 (that's wrong line, sorry)

There are two options:

  • Modify the image tag globally for all Compass components - it would mean that all Compass components (and all Compass teams) will need to switch to Go 1.14. We can try to push it, but it would mean fixing this kind of issues in all Compass components. Hopefully there's not that many issues
  • Duplicate the config and use the 1.14 image tag only for some components (like Director).

I would recommend going with the first option, however it can take a while.

Also, we need to update Dockerfiles for each Compass component (to use alpine with Go 1.14 to build components).

@NickyMateev NickyMateev force-pushed the add-missing-expectation-quotes branch 2 times, most recently from c8ffdd0 to 137bb7a Compare May 5, 2020 14:24
@pkosiec
Copy link
Contributor

pkosiec commented May 5, 2020

/ok-to-test

@pkosiec
Copy link
Contributor

pkosiec commented May 5, 2020

/test all

@NickyMateev
Copy link
Member Author

/retest

@NickyMateev NickyMateev force-pushed the add-missing-expectation-quotes branch from 18e4757 to 840bf33 Compare May 6, 2020 10:13
@NickyMateev
Copy link
Member Author

/test pre-master-compass-integration

@pkosiec pkosiec changed the title Adapt unit tests to work with Go 1.14 Build Compass components with Go 1.14 May 6, 2020
Copy link
Contributor

@Szymongib Szymongib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickyMateev NickyMateev merged commit d068b25 into kyma-incubator:master May 6, 2020
@NickyMateev NickyMateev deleted the add-missing-expectation-quotes branch May 6, 2020 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants