-
Notifications
You must be signed in to change notification settings - Fork 82
Build Compass components with Go 1.14 #1270
Build Compass components with Go 1.14 #1270
Conversation
Hi @NickyMateev. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test all |
@NickyMateev Hmm, the tests won't pass as still on Prow we use older Go while running tests: There are two options:
I would recommend going with the first option, however it can take a while. Also, we need to update Dockerfiles for each Compass component (to use alpine with Go 1.14 to build components). |
c8ffdd0
to
137bb7a
Compare
/ok-to-test |
/test all |
/retest |
18e4757
to
840bf33
Compare
/test pre-master-compass-integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Some unit tests make error assertions which are breaking on Go 1.14.X due to missing quotation signs.
Changes proposed in this pull request:
Reference breaking change in Go: golang/go#37630