-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs that prevented previously-enabled addons from starting up #6471
Conversation
…er was stopped come up successfully
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Error: running mkcmp: exit status 1 |
All Times minikube: [ 101.919553 95.012687 102.323714] Average minikube: 99.751984 Averages Time Per Log
|
Codecov Report
@@ Coverage Diff @@
## master #6471 +/- ##
==========================================
- Coverage 37.99% 37.87% -0.13%
==========================================
Files 128 128
Lines 8729 8757 +28
==========================================
Hits 3317 3317
- Misses 4986 5014 +28
Partials 426 426
|
All Times minikube: [ 99.983179 96.674863 102.425099] Average minikube: 99.694380 Averages Time Per Log
|
All Times minikube: [ 95.919006 97.562193 97.807202] Average minikube: 97.096134 Averages Time Per Log
|
If a cluster is stopped, and then started, we were not enabling previously enabled addons due to two bugs:
/etc/kubernetes/addons
) was not being recreated at startup.Fixes #6456