-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'pause' command to freeze Kubernetes cluster #5962
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change would look nicer if we fixed #5677 first. |
What if we pause the VM in its entirety and then resume it? |
I decided against this approach, for a number of reasons:
|
@tstromberg are you still wokring on this ? |
@medyagh - Yes. |
Codecov Report
@@ Coverage Diff @@
## master #5962 +/- ##
========================================
Coverage ? 37.6%
========================================
Files ? 127
Lines ? 8562
Branches ? 0
========================================
Hits ? 3220
Misses ? 4923
Partials ? 419
|
/ok-to-test |
Error: running mkcmp: exit status 1 |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried locally with docker and it looks good! Just a couple comments.
All Times minikube: [ 97.815426 98.333187 94.732535] Average minikube: 96.960382 Averages Time Per Log
|
Uses the cgroups freezer to reduce minikube's CPU overhead from 30-40% of a core to 1-2% of a core.
By default, it only pauses namespaces populated by minikube, so that applications running on top remain running. This behavior can be overridden by passing
-A
, similar tokubectl
, or by passing--namespaces
.