-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include port names in the 'minikube service' cmd's output #5290
Conversation
Hi @11janci. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 11janci The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @RA489 |
ba7d3bb
to
9d16f7e
Compare
For clarification when reviewing UI changes, it's useful to have a "before" and "after" example. Do you mind adding a "before" example to your PR description? |
done |
Extend the
minikube service {service_name}
command's output by adding a new column 'Target Port' for port names.Pls note that currently the column is included always and will be empty if there are no node ports or target ports. Let me know if you'd like to hide it if empty, add a flag for showing it (as suggested in the linked issue), or rename the column's header.
Before
After
Closes #5200