Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallels support after #953 #3650

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

bassam
Copy link
Contributor

@bassam bassam commented Feb 11, 2019

This PR adds vendor deps for parallels, fixes a compile issue, and enables parallels
as one of the default driver.

It's a continuation of the work in #953 and replaces #2807

/cc @denji @tstromberg

add vendor deps for parallels, fix compile issue, and enable parallels
as a default driver.

Signed-off-by: Bassam Tabbara <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 11, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bassam
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jimmidyson

If they are not already assigned, you can assign the PR to them by writing /assign @jimmidyson in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@afbjorklund
Copy link
Collaborator

Does those vendor changes mean we have to bundle the driver ? Or why can't we just use it as external ?

@tstromberg
Copy link
Contributor

Does those vendor changes mean we have to bundle the driver ? Or why can't we just use it as external ?

Good point. What is the authoritative download location for the driver?

@afbjorklund
Copy link
Collaborator

afbjorklund commented Feb 11, 2019

@bassam
Copy link
Contributor Author

bassam commented Feb 11, 2019

one is a fork of the other. I've use github.com/Parallels/docker-machine-parallels in this PR.

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants