-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parallels support after #953 #3650
Conversation
add vendor deps for parallels, fix compile issue, and enable parallels as a default driver. Signed-off-by: Bassam Tabbara <[email protected]>
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bassam If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Does those vendor changes mean we have to bundle the driver ? Or why can't we just use it as external ? |
Good point. What is the authoritative download location for the driver? |
AFAIK it lives at https://github.com/machine-drivers/docker-machine-parallels Hmm, or maybe that is https://github.com/Parallels/docker-machine-parallels |
one is a fork of the other. I've use |
@minikube-bot OK to test |
This PR adds vendor deps for parallels, fixes a compile issue, and enables parallels
as one of the default driver.
It's a continuation of the work in #953 and replaces #2807
/cc @denji @tstromberg