-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KVM2 driver docs. #2231
KVM2 driver docs. #2231
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2231 +/- ##
==========================================
- Coverage 27.77% 27.75% -0.02%
==========================================
Files 82 82
Lines 5541 5541
==========================================
- Hits 1539 1538 -1
Misses 3807 3807
- Partials 195 196 +1
Continue to review full report at Codecov.
|
``` | ||
curl -LO https://storage.googleapis.com/minikube/releases/latest/docker-machine-driver-kvm2 && chmod +x docker-machine-driver-kvm2 && sudo mv docker-machine-driver-kvm2 /usr/bin/ | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth it to add a line here on how to use it
--vm-driver=kvm2
Hi! Do you plan to keep the KVM2 driver in minikube's tree, or will this be spun off its own repo later on? I'm comparing against @dhiltgen's original driver, and there are many PRs already there that extend it (e.g. using KVM storage pools, using virtio, etc.) that perhaps could be ported to KVM2 soon. |
@dlorenc @zakame to be honest, I don't actually use this driver any more in my day-to-day work, and without any test automation, it's become difficult to make time to test incoming PRs to verify they're working properly. If there's a fork of this on the minikube project that's more active, that might be a better place for PRs to land. I'd be happy to help any transition to help make this easier. |
@dhiltgen thanks, I'm using your driver with some of the PRs applied fairly frequently at my work, so I was a bit concerned about the state here. @dlorenc I took a closer look, and seem like the kvm2 driver is still very minikube-specific (e.g. it pulls the minikube iso instead of boot2docker.) I'd be happy to help out here in any case or form the KVM support takes for docker-machine/minikube. |
Are there any hints why KVM2 is better? |
cc @r2d4