hyperkit: fix hyperkit-vpnkit-sock setting #10631

daehyeok · 2021-02-26T00:21:04Z

k8s-ci-robot · 2021-02-26T00:21:12Z

Hi @daehyeok. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2021-02-26T00:25:03Z

Can one of the admins verify this patch?

medyagh · 2021-02-26T00:51:33Z

@daehyeok currently our mac integration machines are not working, do u mind running the full integration test on the MacBook and share the failuers?

daehyeok · 2021-02-26T06:30:59Z

Here is failed list.
I ran test with env TEST_ARGS="-minikube-start-args=--driver=hyperkit" make integration

❯ cat out/testout_15d95e204.txt | grep FAIL
    helpers_test.go:240: <<< TestMultiNode/serial/RestartMultiNode FAILED: start of post-mortem logs <<<
    multinode_test.go:68: *** TestMultiNode FAILED at 2021-02-25 21:39:26.140953 -0800 PST m=+1691.336968114
    helpers_test.go:240: <<< TestMultiNode FAILED: start of post-mortem logs <<<
--- FAIL: TestMultiNode (862.06s)
    --- FAIL: TestMultiNode/serial (797.46s)
        --- FAIL: TestMultiNode/serial/RestartMultiNode (429.48s)
    panic.go:613: *** TestStoppedBinaryUpgrade FAILED at 2021-02-25 21:48:12.152836 -0800 PST m=+2217.338176019
--- FAIL: TestStoppedBinaryUpgrade (27.73s)
FAIL
FAIL    k8s.io/minikube/test/integration        3031.676s
FAIL

medyagh · 2021-02-26T22:52:31Z

@daehyeok is that the only failure?

medyagh · 2021-02-26T22:54:04Z

/ok-to-test

daehyeok · 2021-02-26T23:51:37Z

@medyagh yes, after 50mins long test, I got only above failes.

❯ tail testout_15d95e204.txt
                --- PASS: TestStartStop/group/no-preload/serial/EnableAddonAfterStop (0.30s)
                --- PASS: TestStartStop/group/no-preload/serial/SecondStart (87.87s)
                --- PASS: TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (22.02s)
                --- PASS: TestStartStop/group/no-preload/serial/AddonExistsAfterStop (5.02s)
                --- PASS: TestStartStop/group/no-preload/serial/VerifyKubernetesImages (0.21s)
                --- PASS: TestStartStop/group/no-preload/serial/Pause (2.60s)
FAIL
Tests completed in 50m30.814462924s (result code 1)
FAIL    k8s.io/minikube/test/integration        3031.676s
FAIL

dytyniuk · 2021-03-01T11:05:27Z

Hey @daehyeok 👋

First of all, thanks for picking this one up 🙇‍♂️
I have downloaded a build and tested it. Unfortunately, the issue persists. Please, check my latest comment here #10443 (comment)

minikube-pr-bot · 2021-03-02T19:10:46Z

kvm2 Driver
Times for minikube: 72.8s 69.8s 70.7s
Average time for minikube: 71.1s

Times for Minikube (PR 10631): 69.1s 71.2s 74.0s
Average time for Minikube (PR 10631): 71.4s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10631) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.0 on Debian               | 0.0s     |                     |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 44.2s    | 43.1s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 2.4s     | 2.2s                |
| on Docker 20.10.3 ...                      |          |                     |
|   - Generating certificates                | 4.0s     | 6.1s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 16.5s    | 16.1s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.4s     | 1.6s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.6s     | 1.6s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.8s     | 0.9s                |
| default-storageclass,                      |          |                     |
| storage-provisioner                        |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 27.2s 27.1s 27.1s
Average time for minikube: 27.1s

Times for Minikube (PR 10631): 28.6s 27.7s 28.2s
Average time for Minikube (PR 10631): 28.2s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10631) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.0 on Debian               | 0.2s     |                     |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 10.2s    | 10.2s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 15.2s    | 16.2s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.1s     | 1.2s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

dytyniuk · 2021-03-03T08:17:05Z

@daehyeok thanks for your help!
@medyagh updated binaries work like a charm - #10443 (comment)

k8s-ci-robot · 2021-03-06T06:23:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daehyeok, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-pr-bot · 2021-03-06T06:40:55Z

kvm2 Driver
Times for minikube: 70.8s 70.5s 70.2s
Average time for minikube: 70.5s

Times for Minikube (PR 10631): 69.9s 70.6s 66.9s
Average time for Minikube (PR 10631): 69.1s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10631) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.0s     |                     |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 44.1s    | 42.8s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 9.0s     | 2.1s                |
| on Docker 20.10.3 ...                      |          |                     |
|   - Generating certificates                | 3.4s     | 4.3s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 10.3s    | 15.8s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.3s     | 1.7s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.4s     | 1.6s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 1.0s     | 0.2s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 27.7s 26.9s 28.2s
Average time for minikube: 27.6s

Times for Minikube (PR 10631): 27.1s 27.7s 26.0s
Average time for Minikube (PR 10631): 26.9s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10631) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     |                     |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 10.5s    | 10.0s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 15.6s    | 15.4s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.0s     | 0.9s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2021

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 26, 2021

k8s-ci-robot requested review from ilya-zuyev and josedonizetti February 26, 2021 00:21

medyagh changed the title ~~Update outdated moby/hyperkit package in minikube code~~ lib: update outdated moby/hyperkit package in minikube code Feb 26, 2021

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2021

medyagh mentioned this pull request Feb 26, 2021

Update outdated moby/hyperkit package in minikube code #10443

Closed

medyagh approved these changes Mar 6, 2021

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2021

daehyeok and others added 2 commits March 5, 2021 22:27

Update outdated moby/hyperkit package in minikube code

fae6740

mod tidy

776f09b

medyagh force-pushed the hyperkit branch from 15d95e2 to 776f09b Compare March 6, 2021 06:28

medyagh changed the title ~~lib: update outdated moby/hyperkit package in minikube code~~ hyperkit: fix hyperkit-vpnkit-sock setting Mar 6, 2021

medyagh added the pr_verified label Mar 6, 2021

medyagh merged commit 01c5eb3 into kubernetes:master Mar 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hyperkit: fix hyperkit-vpnkit-sock setting #10631

hyperkit: fix hyperkit-vpnkit-sock setting #10631

daehyeok commented Feb 26, 2021

k8s-ci-robot commented Feb 26, 2021

minikube-bot commented Feb 26, 2021

medyagh commented Feb 26, 2021

daehyeok commented Feb 26, 2021

medyagh commented Feb 26, 2021

medyagh commented Feb 26, 2021

daehyeok commented Feb 26, 2021

dytyniuk commented Mar 1, 2021

minikube-pr-bot commented Mar 2, 2021

dytyniuk commented Mar 3, 2021

k8s-ci-robot commented Mar 6, 2021

minikube-pr-bot commented Mar 6, 2021

hyperkit: fix hyperkit-vpnkit-sock setting #10631

hyperkit: fix hyperkit-vpnkit-sock setting #10631

Conversation

daehyeok commented Feb 26, 2021

k8s-ci-robot commented Feb 26, 2021

minikube-bot commented Feb 26, 2021

medyagh commented Feb 26, 2021

daehyeok commented Feb 26, 2021

medyagh commented Feb 26, 2021

medyagh commented Feb 26, 2021

daehyeok commented Feb 26, 2021

dytyniuk commented Mar 1, 2021

minikube-pr-bot commented Mar 2, 2021

dytyniuk commented Mar 3, 2021

k8s-ci-robot commented Mar 6, 2021

minikube-pr-bot commented Mar 6, 2021