Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Bump golang version to v1.13.5 #1820

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Bump golang version to v1.13.5 #1820

merged 1 commit into from
Jan 6, 2020

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented Jan 4, 2020

Bump travis build config to use latest golang.

We have already shipped this in Homebrew v0.14.3 (Homebrew/homebrew-core#47394)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 4, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @chenrui333!

It looks like this is your first PR to kubernetes-incubator/kube-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/kube-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mumoshu
You can assign the PR to them by writing /assign @mumoshu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chenrui333
Copy link
Contributor Author

/cc @davidmccormick

@codecov-io
Copy link

Codecov Report

Merging #1820 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1820   +/-   ##
======================================
  Coverage    24.6%   24.6%           
======================================
  Files          98      98           
  Lines        5069    5069           
======================================
  Hits         1247    1247           
  Misses       3682    3682           
  Partials      140     140

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e197df...563bd38. Read the comment docs.

@davidmccormick
Copy link
Contributor

Many thanks for this contribution! 🙏

@davidmccormick davidmccormick merged commit f3e7be4 into kubernetes-retired:master Jan 6, 2020
@davidmccormick davidmccormick added this to the v0.16.0 milestone Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants