Support Zone-Aware Topology in KubeVirt #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
do-not-merge/work-in-progress
kubermatic-bot
added
release-note
kubermatic-bot
added
docs/none
moadqassem
changed the title
kubermatic-bot
removed
the
do-not-merge/work-in-progress
moadqassem
changed the title
kubermatic-bot
added
size/L
moadqassem
force-pushed
the
derive-zone-aware-topo-from-sc-in-kv
branch
3 times, most recently
from
3a6920f to
339aed6
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 22199017977aa65a691d75b4efb05e293972b87e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Some storage providers for KubeVirt support the creation of storage volumes across different regions and zones. This PR derives those specs from the storage class assigned to the VMs as labels in order to make sure that the right pods are run where the volumes are mounted.
In case of multiple zones are supported by a storage class, the topology label will be dropped as it is not possible to add one VM in multi zones, and choosing a random zone out of these zones isn't convenient as users can choose a storage class that explicitly choose one zone.
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: