Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Different Storage Targets for KubeVirt Provider #1855

Merged
merged 5 commits into from
Sep 1, 2024

Conversation

moadqassem
Copy link
Member

@moadqassem moadqassem commented Aug 30, 2024

What this PR does / why we need it:
Currently, machine controller only supports the creation of KubeVirt Data Volumes using PVCs without specifying what storage profile will be used which is quite important for some CSI drivers.
Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind feature

Special notes for your reviewer:
This PR was tested manually with KubeVirt and two machine have been created and they were reflected correctly on the VMs:

spec:
  dataVolumeTemplates:
  - metadata:
      creationTimestamp: null
      name: dv-test-557f6b6c88-2z7g2
    spec:
      source:
        http:
          url: http://remote/host/os
      storage:
        accessModes:
        - ReadWriteOnce
        resources:
          requests:
            storage: 25Gi
        storageClassName: nfs

Does this PR introduce a user-facing change? Then add your Release Note here:

support `storage ` as a another KubeVirt DataVolume storage definition 

Documentation:

None

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 30, 2024
@moadqassem moadqassem changed the title WIP: use KV storage instead of PVC in datavolumes Support Different Storage Targets for KubeVirt Provider Sep 1, 2024
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. labels Sep 1, 2024
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 1, 2024
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dbc9edae3ad76e77a25c6fe174be5dc3cd8eafcd

@yaa110
Copy link

yaa110 commented Sep 1, 2024

/approve
/lgtm

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yaa110

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2024
@kubermatic-bot kubermatic-bot merged commit 69383af into kubermatic:main Sep 1, 2024
12 checks passed
@yaa110
Copy link

yaa110 commented Sep 1, 2024

/lgtm

@moadqassem moadqassem deleted the refactor-kv-pvc branch September 1, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants