-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Hetzner arm64 architecture instances #1816
Conversation
Signed-off-by: 7oku <[email protected]>
Hi @7oku. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Looking good, thank you for the contribution! Let's see if it passes e2e tests. /ok-to-test |
Signed-off-by: 7oku <[email protected]>
Signed-off-by: 7oku <[email protected]>
Signed-off-by: 7oku <[email protected]>
Sorry for causing the merge conflicts. Your change looks good to me and is a useful addition! |
Hey, thanks for updating the PR after the merge conflict. I'm currently checking if we have any concerns with the upgrade to the hcloud-go/v2 version, I'll make sure to get back to you ASAP! |
Hey @embik no problem, we could potentially roll back to hcloud-go/v1 (1.56.0 or so), but according to hetznercloud/hcloud-go#263 (comment) v1 is deprecated since Sep 2023. Upgrading only took the effort to convert int to int64, so not a big deal. Other than here in the Hetzner provider I did not find any other occurrence of hcloud module in machine-controller. @P4sca1 all good, I'm happy to see development on the Hetzner provider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thank you for the contribution, it is greatly appreciated! 🎉
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: fe37d410e7e69454377d3eb04baf840cb31094ff
|
What this PR does / why we need it:
Hetzner provides CAX instances with arm64 architecture. An appropriate image has to be given to the hcloud module, which is suitable for arm64 instances.
The PR implements additional mechanisms to determine the new
hcloud.ServerType.Architecture
field and use the hcloud modules new methodImage.GetForArchitecture()
to determine the correct image for arm64 ServerTypes and allows machine-controller to successful deploy CAX instances.Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind feature
Special notes for your reviewer:
I had to test the change with the latest release of MC (v1.59.2) as my test environment uses kubeone 1.8. The latest changes to MC break the kubernetes deployment, as a lot of flags (use-osm etc.) have been removed in
main
recently. Since I did not touch anything else other than the hetzner provider andmake test-unit
succeeded, it should work fine in upcoming releases. But feel free to test prior accepting the PR.Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: