Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump K8s to 1.31 #655

Closed
wants to merge 2 commits into from
Closed

Bump K8s to 1.31 #655

wants to merge 2 commits into from

Conversation

ArangoGutierrez
Copy link
Contributor

This PR also adds a new example on how to use DRA to claim GPU's for an MPI job

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested a review from carmark October 10, 2024 11:10
@google-oss-prow google-oss-prow bot requested a review from zw0610 October 10, 2024 11:10
@ArangoGutierrez ArangoGutierrez mentioned this pull request Oct 10, 2024
Closed
@tenzen-y
Copy link
Member

@ArangoGutierrez As I mentioned in #654, could you upgrade the k8s version step by step?

@tenzen-y tenzen-y mentioned this pull request Oct 10, 2024
Closed
7 tasks
@ArangoGutierrez
Fix openapi-gen dependency
ee1a2eb 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez
Bump to k8s 1.31
212af30 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez ArangoGutierrez marked this pull request as ready for review October 14, 2024 09:58
@google-oss-prow google-oss-prow bot requested a review from gaocegege October 14, 2024 09:58
tenzen-y
tenzen-y reviewed Oct 14, 2024
View reviewed changes
Makefile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason to modify this Makefile?
I guess that without changes, it should work fine.

go.mod
Comment on lines +3 to +5
go 1.23.0

toolchain go1.23.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
go 1.23.0
toolchain go1.23.1
go 1.23

AFAIK, since Go 1.23, we do not need to specify the toolchain version.

pkg/apis/kubeflow/v2beta1/zz_generated.deepcopy.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep this?

manifests/base/kubeflow.org_mpijobs.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep this?

hack/update-codegen.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for changing this script?

@ArangoGutierrez ArangoGutierrez mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@kannon92 kannon92 kannon92 left review comments

@carmark carmark Awaiting requested review from carmark

@zw0610 zw0610 Awaiting requested review from zw0610

@gaocegege gaocegege Awaiting requested review from gaocegege

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArangoGutierrez @tenzen-y @kannon92