Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for release 0.5.0 #631

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Prepare for release 0.5.0 #631

merged 1 commit into from
Apr 18, 2024

Conversation

alculquicondor
Copy link
Collaborator

@alculquicondor alculquicondor commented Apr 16, 2024 •
edited
Loading

/assign @tenzen-y

I created release notes manually by inspecting v0.4.0...79a9b37

Part-of: #563

@google-oss-prow google-oss-prow bot requested review from carmark and gaocegege April 16, 2024 19:14
@alculquicondor alculquicondor force-pushed the prepare-0.5 branch 2 times, most recently from 29b817e to 0dbcef6 Compare April 16, 2024 19:20
@google-oss-prow google-oss-prow bot added size/XXL and removed size/S labels Apr 16, 2024
@alculquicondor
Copy link
Collaborator Author

/hold
@tenzen-y also wants to upgrade k8s libraries.

terrytangyuan
terrytangyuan approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Apr 17, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@terrytangyuan
Copy link
Member

/assign @tenzen-y

tenzen-y
tenzen-y reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, lgtm

RELEASE.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

go.mod Outdated
@@ -1,6 +1,6 @@
module github.com/kubeflow/mpi-operator

go 1.20
go 1.22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you submit the dedicated PR since all other PRs depend on this Go version update?

This was referenced Apr 17, 2024
Merged
Merged
tenzen-y
tenzen-y reviewed Apr 17, 2024
View reviewed changes
RELEASE.md
@@ -1,5 +1,17 @@
# MPI Operator Releases

## Release v0.5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we mention that we have started to support K8s v1.28 and v1.29?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhm... it should have run before. But I can mention it in the cleanups.

Are we missing any PR before I rebase?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhm... it should have run before. But I can mention it in the cleanups.

That makes sense.

Are we missing any PR before I rebase?

The last piece is #634.

@tenzen-y
Copy link
Member

Part-of: #563

@alculquicondor
Copy link
Collaborator Author

rebased

@alculquicondor
Prepare for release 0.5.0
14c355f 
Signed-off-by: Aldo Culquicondor <[email protected]>
tenzen-y
tenzen-y reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/hold cancel

@google-oss-prow google-oss-prow bot merged commit 52cda2c into kubeflow:master Apr 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@carmark carmark Awaiting requested review from carmark

@gaocegege gaocegege Awaiting requested review from gaocegege

Assignees

@terrytangyuan terrytangyuan

@tenzen-y tenzen-y

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alculquicondor @terrytangyuan @tenzen-y