fix: Path in .terraform.d should contain normalized version.

internal/app/install.go

@@ -165,6 +165,14 @@ func extractMajorVersionAsNumber(version string) int {
 	return number
 }
 
+func normalizeSemver(version string) string {
+	if strings.HasPrefix(version, "v") {
+		return version[1:]
+	}
+
+	return version
+}
+
 func createBuildCommand(providerName string, version string) string {
 	majorVersionNumberAsInt := extractMajorVersionAsNumber(version)
 
@@ -200,6 +208,8 @@ func (a *App) buildProvider(dir string, providerName string, version string) {
 func (a *App) moveBinaryToCorrectLocation(providerName string, version string, executableName string) {
 	if len(version) == 0 {
 		version = "master"
+	} else {
+		version = normalizeSemver(version)
 	}
 
 	filePath := a.Config.TerraformPluginDir + "/registry.terraform.io/" + providerName + "/" + version + "/darwin_arm64"

internal/app/install_test.go

@@ -22,16 +22,27 @@ func TestCreateBuildCommand(t *testing.T) {
 	buildCommand = createBuildCommand("datadog/datadog", "2.35.9")
 	expectedBuildCommand = "make build"
 	if buildCommand != expectedBuildCommand {
-		t.Fatalf("buildCommand should be equal make build")
+		t.Fatalf("buildCommand '%s' should be equal '%s'", buildCommand, expectedBuildCommand)
 	}
 	buildCommand = createBuildCommand("hashicorp/aws", "v2.71.0")
 	expectedBuildCommand = "make tools && make fmt && gofmt -s -w ./tools.go && make build"
 	if buildCommand != expectedBuildCommand {
-		t.Fatalf("buildCommand2 should be equal make build")
+		t.Fatalf("buildCommand '%s' should be equal '%s'", buildCommand, expectedBuildCommand)
 	}
 	buildCommand = createBuildCommand("hashicorp/aws", "v3.0.0")
 	expectedBuildCommand = "cd tools && go get -d github.com/pavius/impi/cmd/impi && cd .. && make tools && make build"
 	if buildCommand != expectedBuildCommand {
-		t.Fatalf("buildCommand3 should be equal make build")
+		t.Fatalf("buildCommand '%s' should be equal '%s'", buildCommand, expectedBuildCommand)
+	}
+}
+
+func TestNormalizeSemver(t *testing.T) {
+	version := normalizeSemver("v2.34.5")
+	if version != "2.34.5" {
+		t.Fatalf("version should be equal 2.34.5, not %s", version)
+	}
+	version = normalizeSemver("2.34.5")
+	if version != "2.34.5" {
+		t.Fatalf("version2 should be equal 2.34.5, not %s", version)
 	}
 }