Full opacity for docked keyboards

It doesn't really make sense for non-opaque docked keyboards. By default all docked keyboards will be fully opaque. You can still explicitly override in dynamic keyboard if you insist.
kmcnaught · Jun 7, 2023 · 69cb83c · 69cb83c
1 parent d3f35bf
commit 69cb83c
Showing 1 changed file with 20 additions and 3 deletions.
diff --git a/src/JuliusSweetland.OptiKey.Core/Services/WindowManipulationService.cs b/src/JuliusSweetland.OptiKey.Core/Services/WindowManipulationService.cs
@@ -622,6 +622,7 @@ public void OverridePersistedState(bool inPersistNewState, string inWindowState,
 
         public void SetOpacityOverride(string opacityString)
         {
+            // Try to parse a string override request
             if (!String.IsNullOrEmpty(opacityString))
             {
                 if (double.TryParse(opacityString, out double opacity))
@@ -630,7 +631,16 @@ public void SetOpacityOverride(string opacityString)
                     return;
                 }
             }
-            window.Opacity = getOpacity();
+            // Otherwise reset to default value 
+            WindowStates windowState = getWindowState();
+            if (windowState == WindowStates.Docked)
+            {
+                window.Opacity = 1.0;
+            }
+            else
+            {
+                window.Opacity = getOpacity();
+            }
         }
 
         public void ResizeDockToCollapsed()
@@ -1016,9 +1026,16 @@ private void ApplySavedState(bool isInitialising = false)
         {
             Log.Info("ApplySavedState called");
 
-            var windowState = getWindowState();
-            window.Opacity = getOpacity();
+            var windowState = getWindowState();            
             var dockPosition = getDockPosition();
+            if (windowState == WindowStates.Docked)
+            {
+                window.Opacity = 1.0;
+            }
+            else
+            {
+                window.Opacity = getOpacity();
+            }
 
             SetResizeState();
             switch (windowState)