Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CDK v2.x #1

Open
kikuomax opened this issue Jan 31, 2022 · 4 comments
Open

Support CDK v2.x #1

kikuomax opened this issue Jan 31, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@kikuomax
Copy link
Owner

Please support CDK v2.x. Maybe in a dedicated branch like v2.x.

@kikuomax kikuomax added the enhancement New feature or request label Jan 31, 2022
@kikuomax kikuomax self-assigned this Jan 31, 2022
@kikuomax
Copy link
Owner Author

I faced this issue before. Is it fixed in the latest aws-lambda-python-alpha?

@kikuomax
Copy link
Owner Author

I faced this issue before. Is it fixed in the latest aws-lambda-python-alpha?

It does not look like so.
aws/aws-cdk#18301 (comment)

@kikuomax
Copy link
Owner Author

I faced this issue before. Is it fixed in the latest aws-lambda-python-alpha?

It does not look like so. aws/aws-cdk#18301 (comment)

As far as I tested, it was fixed since 2.7.0-alpha.0.

@kikuomax
Copy link
Owner Author

aws-lambda-python-alpha does not matter to this project anyway.

kikuomax added a commit that referenced this issue Jan 31, 2022
- `@aws-cdk/core` and `@aws-cdk/aws-lambda` are replaced with
  `constructs` and `aws-cdk-lib`.
- Outdated packages are also updated.

issue #1
kikuomax added a commit that referenced this issue Jan 31, 2022
- `cdk.*` classes are imported from new modules,
    - `Construct` is from `constructs`.
    - `AssetStaging`, `FileSystem`, and `DockerImage` are from
      `aws-cdk-lib`.
- `aws_lambda` is imported as `lambda` from `aws-cdk-lib`.

issue #1
kikuomax added a commit that referenced this issue Jan 31, 2022
- The example project is re-created with the CDK v2. And
  `cdk-python-library-layer` is replaced with
  `cdk2-python-library-layer`.

issue #1
kikuomax added a commit that referenced this issue Jan 31, 2022
- `README.md` and `README_ja.md` are adapted for the version 2.x.

issue #1
kikuomax added a commit that referenced this issue Jan 31, 2022
- The version tagged with "v0.1.0-v2" is installed.

issue #1
kikuomax added a commit that referenced this issue Jan 31, 2022
- `README.md` and `README_ja.md` show a link to the v2.x branch.

issue #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant