Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Android app for Khoj #991

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Create Android app for Khoj #991

merged 5 commits into from
Dec 2, 2024

Conversation

debanjum
Copy link
Member

@debanjum debanjum commented Nov 29, 2024

Use bubblewrap to publish the Khoj Progressive Web App (PWA) as a Trusted Web Activity (TWA) to the Android Play Store.

@debanjum debanjum force-pushed the add-khoj-android-app branch from a1c4a3f to 5d6e0b6 Compare November 29, 2024 19:24
@sabaimran
Copy link
Member

Discussed offline, documenting for posterity.

Many of these files are boilerplate generated by bubblewrap, based off of the khoj web manifest. If/when we are doing a new build, the same files will be regenerated. As such, we've agreed it's not necessary to check in the generated files while we continue to use bubblewrap for development.

Let's document the build/deployment process in src/interface/android.

@debanjum debanjum force-pushed the add-khoj-android-app branch from 5d6e0b6 to b16cb8e Compare December 1, 2024 01:21
…fest

- Add 512, 192 Khoj maskable icons to web app manifest for android rendering
- Add id, categories etc suggested by pwabuilder
- Use higher quality icon images for splash screen than what
  bubblewrap creates by default
- Use bubblewrap generated splash screen, notification icons from
  1200x1200 high res khoj icon in assets.khoj.dev.
- Discard bubblewrap generated launcher icons.
- Fix orientation to respect phone orientation settings. "any" was not.
@debanjum debanjum force-pushed the add-khoj-android-app branch from b16cb8e to ee28d7f Compare December 2, 2024 20:49
@debanjum
Copy link
Member Author

debanjum commented Dec 2, 2024

Discussed offline, documenting for posterity.

Many of these files are boilerplate generated by bubblewrap, based off of the khoj web manifest. If/when we are doing a new build, the same files will be regenerated. As such, we've agreed it's not necessary to check in the generated files while we continue to use bubblewrap for development.

Ok, on further testing, we ended up updating the launcher icons and gradle version in build.gradle etc on top of what bubblewrap was generating. To keep these changes versioned, we'll need to add them to the project as the code generated by bubblewrap is not sufficient and will likely diverge further as we go along.

@debanjum debanjum merged commit 9f7cb33 into master Dec 2, 2024
6 checks passed
@debanjum debanjum deleted the add-khoj-android-app branch December 2, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants