fixed isVarUndefined when the value of variable is boolean false #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
When a variable of like
processBills
:with type Boolean and value false is sent to gotql, gotql interprets the value of the variable as undefined.
This is because of the way the value of the variable is checked for existence.
Currently, it's checked with
!variables[varName].value
And in case the
variables[varName].value
is a boolean false, the expression!variables[varName].value
resolves to a boolean true, which is then returned by the functionisVarUndefined
.To fix this, we should check for the value being undefined simply by doing
variables[varName].value === undefined
Alternate Designs
Why Should This Be here?
It fixes a bug when a variable with a boolean false value is sent to gotql
Benefits
Users will be able to use variables with a boolean false value
Possible Drawbacks
Applicable Issues