Add httpbin_ca_bundle #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@t-8ch: Can you rebase to fix the merge conflicts? |
Configures the pytest_httpbin ca bundle
|
@msabramo done |
|
@t-8ch: Awesome. Thank you! Could give me a short description of the benefit this provides? I was planning to try to do a release of pytest-httpbin 0.0.4 to PyPI and if this PR is ready, I might as well merge it, but I need to know what to put in the release notes. |
|
@t-8ch: Ah, I see, so it's a convenience for the test suite and therefore it probably doesn't have to be mentioned in the release notes, I think. Thanks! |
|
It is also a convenience for the users, as they are using pytest-httpbin in the same way |
|
Oh right, good point! |
msabramo
added a commit
to msabramo/pytest-httpbin
that referenced
this pull request
Dec 2, 2014
|
Cool, probably want to mention in the read me they it will automatically set REQUESTS_CA_BUNDLE if using requests. |
msabramo
added a commit
that referenced
this pull request
Dec 2, 2014
README.md: Add PR #8 to httpbin_ca_bundle change
msabramo
added a commit
to msabramo/pytest-httpbin
that referenced
this pull request
Dec 3, 2014
for 0.0.4. Mention it will automatically set `REQUESTS_CA_BUNDLE` if using requests.
|
@kevin1024: Good idea => #21 |
msabramo
added a commit
that referenced
this pull request
Dec 3, 2014
README.md: Add a bit more info about PR #8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name is a bit unwieldy...