-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase on ESR 128 #10
Comments
whole changes in haiku102 branch |
|
|
It is possible to install |
For now, I lowered required dependency tool/library versions to ones available at HaikuDepot. Because those haikuports had been tested somewhat on Haiku, and it reduces build time. If it doesn't work well, I'll try that. Thanks |
Some servo-related (new?) build errors
|
Can be related to |
Yes I will try it tonight as I will be away from dev PC till night. |
patch in cargo is required even when changing in-tree crates. need to learn how. or works around it
|
external git currently pointed to |
My forks:
External rust crates I touched on haiku102 branch which require forking to patch:
|
It seems that all forks are currently 100% copy of upstream and there are no additional branches. |
Yes I am just preparing work at night. I am away from my own PC on office hour. Will patch those repo and incorporate to build system tonight. Please ignore me until ping to you. |
Maybe just because patches for those not applied yet
|
There are no such thing in Haiku, FD enumeration is done differently using function call instead of file system. That close FD code can be disabled for now.
|
|
WaylandProxy can be disabled with
https://searchfox.org/mozilla-esr128/source/toolkit/xre/nsAppRunner.cpp#4757 |
Fixed almost all compilation errors in branch https://github.com/kenz-gelsoft/gecko-dev/tree/rebase_more_120_patches it start failing link, some fixed with existing patch
|
@X547 Let's try folllowing branch that I believe it https://github.com/kenz-gelsoft/gecko-dev/tree/rebase_runtime_patches I tweaked your changes a bit for consistency. |
That branch successfully built on my environment.
|
Sorry this broke some of your changes. I'm fixing it. |
Pushed bfb858b. Let's try again. |
diff --git a/xpcom/build/BinaryPath.h b/xpcom/build/BinaryPath.h
index 1a84ae4dc878..79844a9d2df3 100644
--- a/xpcom/build/BinaryPath.h
+++ b/xpcom/build/BinaryPath.h
@@ -24,6 +24,10 @@
#if defined(__OpenBSD__)
# include <sys/stat.h>
#endif
+#if defined(__HAIKU__)
+# include <OS.h>
+# include <image.h>
+#endif
#include "mozilla/UniquePtr.h"
#include "mozilla/UniquePtrExtensions.h"
@@ -133,7 +137,7 @@ class BinaryPath {
return rv;
}
-#elif defined(ANDROID) || defined(__HAIKU__)
+#elif defined(ANDROID)
static nsresult Get(char aResult[MAXPATHLEN]) {
// On Android, we use the MOZ_ANDROID_LIBDIR variable that is set by the
// Java bootstrap code.
@@ -257,6 +261,21 @@ class BinaryPath {
return NS_ERROR_FAILURE;
}
+#elif defined(__HAIKU__)
+ static nsresult Get(char aResult[MAXPATHLEN]) {
+ image_info info;
+ int32 cookie = 0;
+
+ while (get_next_image_info(B_CURRENT_TEAM, &cookie, &info) >= B_OK) {
+ if (info.type == B_APP_IMAGE) {
+ strlcpy(aResult, info.name, MAXPATHLEN - 1);
+ return NS_OK;
+ }
+ }
+
+ return NS_ERROR_FAILURE;
+ }
+
#else
# error Oops, you need platform-specific code here
#endif |
Sorry one more commit f2a92d9. I'll go work now. Good luck. |
I guess my patched version has the same version number, cargo may find already compiled version on your cargo build cache, and it conflicts content hash, I have no luck on googling this a bit:
I try changing another patching option |
it seems I need to bump patched crates versions
|
rkv crates depends on lmdb-rkv so I need to fork this too.
and glean-core depends on it...
|
I reworked to incorporate patched rust crates on @X547 you should be able to build on this branch. https://github.com/kenz-gelsoft/gecko-dev/pull/25/files |
|
Hmm, it seems lacking |
Link failure on two archives
They looks corresponding to these:
I'll check build script for those modules today. Sorry, I'll go out to meet friend, so maybe I'll respond tonight (in JST) |
I am located in Japan, Kansai region, so JST too. |
I couldn't find the cause of the link error why I can build and you can't. Though adding libnetwork to linker input should fix your problem. This is the branch, please try. https://github.com/kenz-gelsoft/gecko-dev/tree/link_libnetwork_explicitly 5c1a1e8 is the change. |
It is working: https://discuss.haiku-os.org/t/progress-on-porting-firefox/13493/143 Any ideas why video codecs are not enabled? |
Nice progress. I don't mind investigating video codec build errors, but I don't get working successfully like you. Do you run it with unreleased newer mesa+lvgnd on your PC? |
Putting that aside, I finally close this Issue. |
Have you tried to install |
I didn't try it because not yet available from HaikuDepot. Can I install it build haikuport manually? |
BTW, two branches I asked you try are now merged into haiku128. |
You can build |
Thanks, I installed glvnd, it fixed glxtest error, but it doesn't work well. This may be caused as I'm using in-tree libevent and its build setting may be not good as Haikuports version.
(I accidentally removed libevent_devel as recent Haikuports dependency change.) |
wayland-server problems. |
|
AFAIK, It is informative that the widget level event passing is handled by |
I tried this branch by replacing haikuports revision (and checksum), but none of these improved. https://github.com/X547/wayland-server/commits/haiku-shm/ are you experiencing same problems, and not solved yet? |
ESR128 is fresh and can be built with wayland only.
It should be suitable for new target branch.
The text was updated successfully, but these errors were encountered: