Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pad_aspect and animations do not play nicely #18

Open
kecnry opened this issue Nov 8, 2017 · 1 comment
Open

pad_aspect and animations do not play nicely #18

kecnry opened this issue Nov 8, 2017 · 1 comment
Labels
bug

Comments

@kecnry
Copy link
Owner

kecnry commented Nov 8, 2017

especially for meshes in an orbit. Pad_aspect will override the fixed limits on a per-frame basis, giving unintended results.
@kecnry kecnry added the bug label Nov 8, 2017
kecnry added a commit to phoebe-project/phoebe2 that referenced this issue Sep 17, 2018
@kecnry
ignore pad_aspect within animation so that auto limits work
c0ebbb3 
see kecnry/autofig#18 for more details
kecnry added a commit that referenced this issue Sep 17, 2018
@kecnry
ignore pad_aspect for animations
433b32a 
temporary solution to #18.  Fixing this once and for all will require writing a custom callback (in callbacks.py) within the resize/zoom to manually pad the datalimits instead of using matplotlib's native behavior for set_aspect like we do now.  But with this temporary fix, pad_aspect=True will be ignored for animations, but the automatic axes limits will still be respected and set correctly.
@kecnry
Copy link
Owner Author

kecnry commented Sep 17, 2018

Although this is somewhat temporarily fixed by ignoring pad_aspect, I'll leave this open so that the real fix can hopefully be implemented (see the comment in the commit above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kecnry