feat: Allows setting wildcards for SkippedPropagatingNamespaces

[chaunceyjiang]

What type of PR is this?
/kind feature

What this PR does / why we need it:

Allows user settings to skip namespace propagation with specific prefixes/suffixes.

Like: openshift-xxxxxx

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: Allows setting wildcards for `--skippedPropagatingNamespaces` flag.

[codecov-commenter]

Codecov Report

Merging #3373 (8b701db) into master (cbf5c4a) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3373      +/-   ##
==========================================
- Coverage   51.69%   51.59%   -0.10%     
==========================================
  Files         210      210              
  Lines       18931    18927       -4     
==========================================
- Hits         9786     9766      -20     
- Misses       8619     8633      +14     
- Partials      526      528       +2     

Flag	Coverage Δ
unittests	51.59% <0.00%> (-0.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/controller-manager/app/options/validation.go	87.09% <0.00%> (-12.91%)	⬇️
pkg/detector/detector.go	0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[XiShanYongYe-Chang]

Hi @chaunceyjiang, can you give some examples of how to use this parameter?

[chaunceyjiang]

Hi @chaunceyjiang, can you give some examples of how to use this parameter?

Example:

 --skipped-propagating-namespaces=openshift-.*,example-namespace,.*-ns-suffixes

[XiShanYongYe-Chang]

Thanks~

[XiShanYongYe-Chang]

/lgtm

[chaunceyjiang]

Hi @RainbowMango Can you help to re-trigger e2e?

[RainbowMango]

/assign

[chaunceyjiang]

BenchmarkEventFilterNoSkipNameSpaces-8 is the benchmark of the original function.

Each operation takes about 522.4ns , which I think is acceptable. What do you think? @RainbowMango

[RainbowMango]

I tested the BenchmarkEventFilterNoMatchSkipNameSpaces on my side and compared the performance changes before and after the patch(by benchstat), seems that this patch got 4.4% slower than before:

# benchstat BenchmarkEventFilterNoMatchSkipNameSpaces.before BenchmarkEventFilterNoMatchSkipNameSpaces.after 
goos: linux
goarch: amd64
pkg: github.com/karmada-io/karmada/pkg/detector
cpu: Intel(R) Xeon(R) Gold 6278C CPU @ 2.60GHz
                                   │ BenchmarkEventFilterNoMatchSkipNameSpaces.before │ BenchmarkEventFilterNoMatchSkipNameSpaces.after │
                                   │                      sec/op                      │          sec/op           vs base               │
EventFilterNoMatchSkipNameSpaces-4                                        1.199µ ± 1%                1.252µ ± 1%  +4.42% (p=0.000 n=15)

This seems acceptable, I'm surprised by the result though. I guess the reason might be we pre-compile the regular expression when parsing raw options at here.

[chaunceyjiang]

The compilation does have a large impact on the speed:

golang/go#26623 (comment)

[RainbowMango]

Yes, thanks, I will look at the ASAP.

[RainbowMango]

Generally looks good to me, with some nits.

[chaunceyjiang]

Done.

/cc @RainbowMango

[RainbowMango]

/lgtm
/approve
Thanks for your quick response 👍

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment